summaryrefslogtreecommitdiffstats
path: root/mm
diff options
context:
space:
mode:
authorMichał Kępień <kernel@kempniu.pl>2018-03-10 21:43:53 +0100
committerDarren Hart (VMware) <dvhart@infradead.org>2018-03-21 16:28:14 -0700
commit502ab004e6c4426b91460d8be8b9d4a4bf206657 (patch)
tree23905bc2ce730a044c2083218e9bd38b7a3aca2c /mm
parent7129707ec2356ef9ef9cce469ad14eb37fbbe67e (diff)
downloadlinux-502ab004e6c4426b91460d8be8b9d4a4bf206657.tar.bz2
platform/x86: fujitsu-laptop: Revert UNSUPPORTED_CMD back to an int
UNSUPPORTED_CMD was previously 0x80000000 (int), but commit 819cddae7cfa ("platform/x86: fujitsu-laptop: Clean up constants") changed it into an unsigned long due to BIT() being used to define it. As call_fext_func() returns an int, 0x80000000 would get type promoted when compared to an unsigned long, which on a 64-bit system would cause it to become 0xffffffff80000000 due to sign extension. This causes one logical condition in fujitsu-laptop to always be true and another one to always be false on 64-bit systems. Fix this by reverting UNSUPPORTED_CMD back to an int. This patch fixes the following smatch warnings: drivers/platform/x86/fujitsu-laptop.c:763 acpi_fujitsu_laptop_leds_register() warn: always true condition '(call_fext_func(device, ((1 << (12)) | (1 << (0))), 2, (1 << (16)), 0) != (1 << (31))) => (s32min-s32max != 2147483648)' drivers/platform/x86/fujitsu-laptop.c:816 acpi_fujitsu_laptop_add() warn: impossible condition '(priv->flags_supported == (1 << (31))) => (0-2147483647,18446744071562067968-u64max == 2147483648)' Fixes: 819cddae7cfa ("platform/x86: fujitsu-laptop: Clean up constants") Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Michał Kępień <kernel@kempniu.pl> Reviewed-by: Jonathan Woithe <jwoithe@just42.net> Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
Diffstat (limited to 'mm')
0 files changed, 0 insertions, 0 deletions