diff options
| author | SeongJae Park <sj@kernel.org> | 2022-06-04 19:50:51 +0000 |
|---|---|---|
| committer | akpm <akpm@linux-foundation.org> | 2022-06-16 19:11:30 -0700 |
| commit | 2949282938135ab734c3829495ae393523ceb702 (patch) | |
| tree | e0f683505497ac250591c65d7a60f7a681eb649a /mm/mmap_lock.c | |
| parent | d25c83c6606ffc3abdf0868136ad3399f648ad70 (diff) | |
| download | linux-2949282938135ab734c3829495ae393523ceb702.tar.bz2 | |
mm/damon/reclaim: schedule 'damon_reclaim_timer' only after 'system_wq' is initialized
Commit 059342d1dd4e ("mm/damon/reclaim: fix the timer always stays
active") made DAMON_RECLAIM's 'enabled' parameter store callback,
'enabled_store()', to schedule 'damon_reclaim_timer'. The scheduling uses
'system_wq', which is initialized in 'workqueue_init_early()'. As kernel
parameters parsing function ('parse_args()') is called before
'workqueue_init_early()', 'enabled_store()' can be executed before
'workqueue_init_early()' and end up accessing the uninitialized
'system_wq'. As a result, the booting hang[1]. This commit fixes the
issue by checking if the initialization is done before scheduling the
timer.
[1] https://lkml.kernel.org/20220604192222.1488-1-sj@kernel.org/
Link: https://lkml.kernel.org/r/20220604195051.1589-1-sj@kernel.org
Fixes: 059342d1dd4e ("mm/damon/reclaim: fix the timer always stays active")
Signed-off-by: SeongJae Park <sj@kernel.org>
Reported-by: Greg White <gwhite@kupulau.com>
Cc: Hailong Tu <tuhailong@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'mm/mmap_lock.c')
0 files changed, 0 insertions, 0 deletions