diff options
author | Julia Lawall <julia.lawall@lip6.fr> | 2015-10-10 23:41:42 +0200 |
---|---|---|
committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2015-10-26 10:58:26 +0000 |
commit | a4283e41bbd80c629770f954cc5d013eb8851229 (patch) | |
tree | 1e031075315b2f1d286f21c036293139984216ff /lib | |
parent | 9254970cbbf542a0085e491810f0144a27885702 (diff) | |
download | linux-a4283e41bbd80c629770f954cc5d013eb8851229.tar.bz2 |
arm: add missing of_node_put
for_each_child_of_node performs an of_node_get on each iteration, so
a break out of the loop requires an of_node_put.
The of_node_put is duplicated in front of each error return, because the
function contains a later error return that is beyond the end of the
for_each_child_of_node and thus doesn't need of_node_put.
The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr):
// <smpl>
@@
expression root,e;
local idexpression child;
iterator name for_each_child_of_node;
@@
for_each_child_of_node(root, child) {
... when != of_node_put(child)
when != e = child
(
return child;
|
+ of_node_put(child);
? return ...;
)
...
}
@@
expression root,e;
local idexpression child;
@@
for_each_child_of_node(root, child) {
... when != of_node_put(child)
when != e = child
+ of_node_put(child);
? break;
...
}
... when != child
// </smpl>
Additionally, concatenated a string in an affected line to avoid introducing
a checkpatch warning.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions