diff options
author | Jeff Layton <jlayton@redhat.com> | 2017-07-06 07:02:24 -0400 |
---|---|---|
committer | Jeff Layton <jlayton@redhat.com> | 2017-07-06 07:02:24 -0400 |
commit | 5e8fcc1a0ffa0fb794b3c0efa2c3c7612a771c36 (patch) | |
tree | 2df735706ee4006f12f2ab77fd24e7ae019310fe /lib/zlib_inflate | |
parent | cbeaf9510a8631e9bb0077a95fd8b0db0b3be200 (diff) | |
download | linux-5e8fcc1a0ffa0fb794b3c0efa2c3c7612a771c36.tar.bz2 |
mm: don't TestClearPageError in __filemap_fdatawait_range
The -EIO returned here can end up overriding whatever error is marked in
the address space, and be returned at fsync time, even when there is a
more appropriate error stored in the mapping.
Read errors are also sometimes tracked on a per-page level using
PG_error. Suppose we have a read error on a page, and then that page is
subsequently dirtied by overwriting the whole page. Writeback doesn't
clear PG_error, so we can then end up successfully writing back that
page and still return -EIO on fsync.
Worse yet, PG_error is cleared during a sync() syscall, but the -EIO
return from that is silently discarded. Any subsystem that is relying on
PG_error to report errors during fsync can easily lose writeback errors
due to this. All you need is a stray sync() call to wait for writeback
to complete and you've lost the error.
Since the handling of the PG_error flag is somewhat inconsistent across
subsystems, let's just rely on marking the address space when there are
writeback errors. Change the TestClearPageError call to ClearPageError,
and make __filemap_fdatawait_range a void return function.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Diffstat (limited to 'lib/zlib_inflate')
0 files changed, 0 insertions, 0 deletions