diff options
| author | Mauro Carvalho Chehab <mchehab+samsung@kernel.org> | 2019-05-24 10:59:43 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-05-24 21:09:20 +0200 |
| commit | a47686636d84eaec5c9c6e84bd5f96bed34d526d (patch) | |
| tree | a91a54162e8114f2f406a739c89554e90181793a /lib/seq_buf.c | |
| parent | c1a145a3ed9a40f3b6145feb97789e8eb49c5566 (diff) | |
| download | linux-a47686636d84eaec5c9c6e84bd5f96bed34d526d.tar.bz2 | |
media: smsusb: better handle optional alignment
Most Siano devices require an alignment for the response.
Changeset f3be52b0056a ("media: usb: siano: Fix general protection fault in smsusb")
changed the logic with gets such aligment, but it now produces a
sparce warning:
drivers/media/usb/siano/smsusb.c: In function 'smsusb_init_device':
drivers/media/usb/siano/smsusb.c:447:37: warning: 'in_maxp' may be used uninitialized in this function [-Wmaybe-uninitialized]
447 | dev->response_alignment = in_maxp - sizeof(struct sms_msg_hdr);
| ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
The sparse message itself is bogus, but a broken (or fake) USB
eeprom could produce a negative value for response_alignment.
So, change the code in order to check if the result is not
negative.
Fixes: 31e0456de5be ("media: usb: siano: Fix general protection fault in smsusb")
CC: <stable@vger.kernel.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'lib/seq_buf.c')
0 files changed, 0 insertions, 0 deletions