summaryrefslogtreecommitdiffstats
path: root/lib/parser.c
diff options
context:
space:
mode:
authorKees Cook <keescook@chromium.org>2018-09-28 15:17:50 -0700
committerKees Cook <keescook@chromium.org>2018-09-30 10:15:41 -0700
commitbac6f6cda206ad7cbe0c73c35e494377ce9c4749 (patch)
treebaf7c12f5ba0069ea47da897a8be25f43fc5ab2c /lib/parser.c
parent831b624df1b420c8f9281ed1307a8db23afb72df (diff)
downloadlinux-bac6f6cda206ad7cbe0c73c35e494377ce9c4749.tar.bz2
pstore/ram: Fix failure-path memory leak in ramoops_init
As reported by nixiaoming, with some minor clarifications: 1) memory leak in ramoops_register_dummy(): dummy_data = kzalloc(sizeof(*dummy_data), GFP_KERNEL); but no kfree() if platform_device_register_data() fails. 2) memory leak in ramoops_init(): Missing platform_device_unregister(dummy) and kfree(dummy_data) if platform_driver_register(&ramoops_driver) fails. I've clarified the purpose of ramoops_register_dummy(), and added a common cleanup routine for all three failure paths to call. Reported-by: nixiaoming <nixiaoming@huawei.com> Cc: stable@vger.kernel.org Cc: Anton Vorontsov <anton@enomsg.org> Cc: Colin Cross <ccross@android.com> Cc: Tony Luck <tony.luck@intel.com> Cc: Joel Fernandes <joelaf@google.com> Cc: Geliang Tang <geliangtang@gmail.com> Signed-off-by: Kees Cook <keescook@chromium.org>
Diffstat (limited to 'lib/parser.c')
0 files changed, 0 insertions, 0 deletions