diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2015-10-22 11:02:50 +0200 |
---|---|---|
committer | Rob Herring <robh@kernel.org> | 2015-10-22 09:26:28 -0500 |
commit | 855ff2878ec5ef15f0a69a528b2ca676edfb3ee4 (patch) | |
tree | 5a0be890d65d0e5aabbaaa289f5a1e8fbcfec5ca /lib/842 | |
parent | e300745a4c60f424eaf7c7b7cc6bab3e56380c89 (diff) | |
download | linux-855ff2878ec5ef15f0a69a528b2ca676edfb3ee4.tar.bz2 |
of/unittest: add missing of_node_put
for_each_child_of_node performs an of_node_get on each iteration, so
a break out of the loop requires an of_node_put.
A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr):
// <smpl>
@@
expression root,e;
local idexpression child;
@@
for_each_child_of_node(root, child) {
... when != of_node_put(child)
when != e = child
(
return child;
|
+ of_node_put(child);
? return ...;
)
...
}
// </smpl>
Combine the puts into code at the end of the function, for conciseness.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Rob Herring <robh@kernel.org>
Diffstat (limited to 'lib/842')
0 files changed, 0 insertions, 0 deletions