diff options
author | Kumar Kartikeya Dwivedi <memxor@gmail.com> | 2022-03-19 13:38:23 +0530 |
---|---|---|
committer | Alexei Starovoitov <ast@kernel.org> | 2022-04-06 10:32:12 -0700 |
commit | be77354a3d7ebd4897ee18eca26dca6df9224c76 (patch) | |
tree | 41583e459f138fe44366ed0beb6a0900c9955d1f /kernel/cfi.c | |
parent | ebaf24c589d7c714b763a80856d1a6df3ba25b84 (diff) | |
download | linux-be77354a3d7ebd4897ee18eca26dca6df9224c76.tar.bz2 |
bpf: Do write access check for kfunc and global func
When passing pointer to some map value to kfunc or global func, in
verifier we are passing meta as NULL to various functions, which uses
meta->raw_mode to check whether memory is being written to. Since some
kfunc or global funcs may also write to memory pointers they receive as
arguments, we must check for write access to memory. E.g. in some case
map may be read only and this will be missed by current checks.
However meta->raw_mode allows for uninitialized memory (e.g. on stack),
since there is not enough info available through BTF, we must perform
one call for read access (raw_mode = false), and one for write access
(raw_mode = true).
Fixes: e5069b9c23b3 ("bpf: Support pointers in global func args")
Fixes: d583691c47dc ("bpf: Introduce mem, size argument pair support for kfunc")
Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
Link: https://lore.kernel.org/r/20220319080827.73251-2-memxor@gmail.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Diffstat (limited to 'kernel/cfi.c')
0 files changed, 0 insertions, 0 deletions