diff options
author | Jan Kara <jack@suse.cz> | 2019-07-30 13:10:14 +0200 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2019-07-30 13:16:57 -0600 |
commit | 89e524c04fa966330e2e80ab2bc50b9944c5847a (patch) | |
tree | b384005acf4d525150d0a8eb0d7a62b33a44e798 /kernel/auditsc.c | |
parent | 71d6c505b4d9e6f76586350450e785e3d452b346 (diff) | |
download | linux-89e524c04fa966330e2e80ab2bc50b9944c5847a.tar.bz2 |
loop: Fix mount(2) failure due to race with LOOP_SET_FD
Commit 33ec3e53e7b1 ("loop: Don't change loop device under exclusive
opener") made LOOP_SET_FD ioctl acquire exclusive block device reference
while it updates loop device binding. However this can make perfectly
valid mount(2) fail with EBUSY due to racing LOOP_SET_FD holding
temporarily the exclusive bdev reference in cases like this:
for i in {a..z}{a..z}; do
dd if=/dev/zero of=$i.image bs=1k count=0 seek=1024
mkfs.ext2 $i.image
mkdir mnt$i
done
echo "Run"
for i in {a..z}{a..z}; do
mount -o loop -t ext2 $i.image mnt$i &
done
Fix the problem by not getting full exclusive bdev reference in
LOOP_SET_FD but instead just mark the bdev as being claimed while we
update the binding information. This just blocks new exclusive openers
instead of failing them with EBUSY thus fixing the problem.
Fixes: 33ec3e53e7b1 ("loop: Don't change loop device under exclusive opener")
Cc: stable@vger.kernel.org
Tested-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'kernel/auditsc.c')
0 files changed, 0 insertions, 0 deletions