diff options
author | Hou Tao <houtao1@huawei.com> | 2020-09-15 22:07:50 +0800 |
---|---|---|
committer | Peter Zijlstra <peterz@infradead.org> | 2020-09-16 16:26:56 +0200 |
commit | e6b1a44eccfcab5e5e280be376f65478c3b2c7a2 (patch) | |
tree | 2175cb1bc02e8b795a2ebb5d3fe5263539e5cb4f /ipc/util.c | |
parent | 23870f1227680d2aacff6f79c3ab2222bd04e86e (diff) | |
download | linux-e6b1a44eccfcab5e5e280be376f65478c3b2c7a2.tar.bz2 |
locking/percpu-rwsem: Use this_cpu_{inc,dec}() for read_count
The __this_cpu*() accessors are (in general) IRQ-unsafe which, given
that percpu-rwsem is a blocking primitive, should be just fine.
However, file_end_write() is used from IRQ context and will cause
load-store issues on architectures where the per-cpu accessors are not
natively irq-safe.
Fix it by using the IRQ-safe this_cpu_*() for operations on
read_count. This will generate more expensive code on a number of
platforms, which might cause a performance regression for some of the
other percpu-rwsem users.
If any such is reported, we can consider alternative solutions.
Fixes: 70fe2f48152e ("aio: fix freeze protection of aio writes")
Signed-off-by: Hou Tao <houtao1@huawei.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Will Deacon <will@kernel.org>
Acked-by: Oleg Nesterov <oleg@redhat.com>
Link: https://lkml.kernel.org/r/20200915140750.137881-1-houtao1@huawei.com
Diffstat (limited to 'ipc/util.c')
0 files changed, 0 insertions, 0 deletions