summaryrefslogtreecommitdiffstats
path: root/init
diff options
context:
space:
mode:
authorJann Horn <jannh@google.com>2019-10-18 22:56:29 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-11-14 11:44:46 +0800
commit8eb52a1ee37aafd9b796713aa0b3ab9cbc455be3 (patch)
tree5263874068ffdda554cdb83c897728299b898d9d /init
parent60f8a59ddcdc7fb7c17180ba10d9c49bc91156c7 (diff)
downloadlinux-8eb52a1ee37aafd9b796713aa0b3ab9cbc455be3.tar.bz2
binder: Fix race between mmap() and binder_alloc_print_pages()
binder_alloc_print_pages() iterates over alloc->pages[0..alloc->buffer_size-1] under alloc->mutex. binder_alloc_mmap_handler() writes alloc->pages and alloc->buffer_size without holding that lock, and even writes them before the last bailout point. Unfortunately we can't take the alloc->mutex in the ->mmap() handler because mmap_sem can be taken while alloc->mutex is held. So instead, we have to locklessly check whether the binder_alloc has been fully initialized with binder_alloc_get_vma(), like in binder_alloc_new_buf_locked(). Fixes: 8ef4665aa129 ("android: binder: Add page usage in binder stats") Cc: stable@vger.kernel.org Signed-off-by: Jann Horn <jannh@google.com> Acked-by: Christian Brauner <christian.brauner@ubuntu.com> Link: https://lore.kernel.org/r/20191018205631.248274-1-jannh@google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'init')
0 files changed, 0 insertions, 0 deletions