summaryrefslogtreecommitdiffstats
path: root/include
diff options
context:
space:
mode:
authorOkash Khawaja <okash.khawaja@gmail.com>2017-06-20 11:07:32 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-06-25 16:31:22 +0200
commite4dd8bca3d5153503c1c923feb5c056124ea56ae (patch)
tree9d6eca19b138a33124078ad430c674b1682d5cbe /include
parenteebdd3f61bac853e1a42acc59f18c642d2a02eef (diff)
downloadlinux-e4dd8bca3d5153503c1c923feb5c056124ea56ae.tar.bz2
staging: speakup: fix synth caching when synth init fails
synths[] array caches currently loaded synths. synth_add checks synths[] before adding a new one. It however ignores the result of do_synth_init. So when do_synth_init fails, the failed synth is still cached. Since, as a result module loading fails too, synth_remove - which is responsible for removing the cached synth - is never called. Next time the failing synth is added again it succeeds because synth_add finds it cached inside synths[]. This patch fixes this by caching a synth only after do_synth_init succeeds. Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com> Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions