summaryrefslogtreecommitdiffstats
path: root/include
diff options
context:
space:
mode:
authorMatthew Whitehead <tedheadster@gmail.com>2019-03-14 16:46:00 -0400
committerThomas Gleixner <tglx@linutronix.de>2019-03-21 12:28:50 +0100
commit18fb053f9b827bd98cfc64f2a35df8ab19745a1d (patch)
tree5c283a132e09035e7ed331f24562f6367c84c37d /include
parent9bd681251b7c1db1c6cfe29a72c5ea1b1c0ba022 (diff)
downloadlinux-18fb053f9b827bd98cfc64f2a35df8ab19745a1d.tar.bz2
x86/cpu/cyrix: Use correct macros for Cyrix calls on Geode processors
There are comments in processor-cyrix.h advising you to _not_ make calls using the deprecated macros in this style: setCx86_old(CX86_CCR4, getCx86_old(CX86_CCR4) | 0x80); This is because it expands the macro into a non-functioning calling sequence. The calling order must be: outb(CX86_CCR2, 0x22); inb(0x23); From the comments: * When using the old macros a line like * setCx86(CX86_CCR2, getCx86(CX86_CCR2) | 0x88); * gets expanded to: * do { * outb((CX86_CCR2), 0x22); * outb((({ * outb((CX86_CCR2), 0x22); * inb(0x23); * }) | 0x88), 0x23); * } while (0); The new macros fix this problem, so use them instead. Tested on an actual Geode processor. Signed-off-by: Matthew Whitehead <tedheadster@gmail.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: luto@kernel.org Link: https://lkml.kernel.org/r/1552596361-8967-2-git-send-email-tedheadster@gmail.com
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions