diff options
author | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2020-09-01 11:05:19 +0200 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2020-09-03 11:07:57 +0200 |
commit | 7a9b56123a036483d3b26bbd37d0dab4ca4c9eae (patch) | |
tree | 0a45566554b6bf9715b48325e0ec67a16384f103 /include | |
parent | ddc11db26ccbd40ccb42449b747c86c12f2ec636 (diff) | |
download | linux-7a9b56123a036483d3b26bbd37d0dab4ca4c9eae.tar.bz2 |
media: qt1010: fix usage of unititialized value
As pointed by smatch:
drivers/media/tuners/qt1010.c:239 qt1010_init_meas1() error: uninitialized symbol 'val2'.
drivers/media/tuners/qt1010.c:273 qt1010_init_meas2() error: uninitialized symbol 'val'.
The logic is ok, but it is hard for static analyzers
to parse it, as it depends on a value read in the middle
of a loop.
Also, it takes a while for humans to verify.
Re-write the first function to use a more direct way.
At the second one, I opted to just initialize the read var,
in order to shut up the report.
While here, address a few coding style issues at the
function code.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions