diff options
author | Jiri Pirko <jiri@mellanox.com> | 2016-05-17 18:58:08 +0200 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2016-05-17 13:58:49 -0400 |
commit | da4ed55165d41b1073f9a476f1c18493e9bf8c8e (patch) | |
tree | 0971053bdbdb27fe6d0f9e801411ae94f0a8974d /include | |
parent | dc327f8931cb9d66191f489eb9a852fc04530546 (diff) | |
download | linux-da4ed55165d41b1073f9a476f1c18493e9bf8c8e.tar.bz2 |
switchdev: pass pointer to fib_info instead of copy
The problem is that fib_info->nh is [0] so the struct fib_info
allocation size depends on number of nexthops. If we just copy fib_info,
we do not copy the nexthops info and driver accesses memory which is not
ours.
Given the fact that fib4 does not defer operations and therefore it does
not need copy, just pass the pointer down to drivers as it was done
before.
Fixes: 850d0cbc91 ("switchdev: remove pointers from switchdev objects")
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include')
-rw-r--r-- | include/net/switchdev.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/net/switchdev.h b/include/net/switchdev.h index 51d77b2ce2b2..985619a59323 100644 --- a/include/net/switchdev.h +++ b/include/net/switchdev.h @@ -97,7 +97,7 @@ struct switchdev_obj_ipv4_fib { struct switchdev_obj obj; u32 dst; int dst_len; - struct fib_info fi; + struct fib_info *fi; u8 tos; u8 type; u32 nlflags; |