diff options
| author | NeilBrown <neilb@suse.de> | 2010-03-16 15:14:51 +1100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-05-21 09:37:29 -0700 |
| commit | db1afffab0b5d9f6d31f8f4bea44c9cb3bc59351 (patch) | |
| tree | 5ba8fd7a5018c0772d999b8c3aa945c0efb929e0 /include | |
| parent | dd336c554d8926c3348a2d5f2a5ef5597f6d1a06 (diff) | |
| download | linux-db1afffab0b5d9f6d31f8f4bea44c9cb3bc59351.tar.bz2 | |
kref: remove kref_set
Of the three uses of kref_set in the kernel:
One really should be kref_put as the code is letting go of a
reference,
Two really should be kref_init because the kref is being
initialised.
This suggests that making kref_set available encourages bad code.
So fix the three uses and remove kref_set completely.
Signed-off-by: NeilBrown <neilb@suse.de>
Acked-by: Mimi Zohar <zohar@us.ibm.com>
Acked-by: Serge Hallyn <serue@us.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'include')
| -rw-r--r-- | include/linux/kref.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/include/linux/kref.h b/include/linux/kref.h index baf4b9e4b194..6cc38fc07ab7 100644 --- a/include/linux/kref.h +++ b/include/linux/kref.h @@ -21,7 +21,6 @@ struct kref { atomic_t refcount; }; -void kref_set(struct kref *kref, int num); void kref_init(struct kref *kref); void kref_get(struct kref *kref); int kref_put(struct kref *kref, void (*release) (struct kref *kref)); |