diff options
author | Thomas Gleixner <tglx@linutronix.de> | 2007-12-18 18:05:58 +0100 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2007-12-18 18:05:58 +0100 |
commit | cdc6f27d9e3c2f7ca1a3e19c6eabb1ad6a2add5d (patch) | |
tree | d557b594cd5d180e1ce91cac25a29d81a42499a5 /include | |
parent | bd87f1f028ddaad45d4a9a3621dfe688c840ba41 (diff) | |
download | linux-cdc6f27d9e3c2f7ca1a3e19c6eabb1ad6a2add5d.tar.bz2 |
clockevents: fix reprogramming decision in oneshot broadcast
Resolve the following regression of a choppy, almost unusable laptop:
http://lkml.org/lkml/2007/12/7/299
http://bugzilla.kernel.org/show_bug.cgi?id=9525
A previous version of the code did the reprogramming of the broadcast
device in the return from idle code. This was removed, but the logic in
tick_handle_oneshot_broadcast() was kept the same.
When a broadcast interrupt happens we signal the expiry to all CPUs
which have an expired event. If none of the CPUs has an expired event,
which can happen in dyntick mode, then we reprogram the broadcast
device. We do not reprogram otherwise, but this is only correct if all
CPUs, which are in the idle broadcast state have been woken up.
The code ignores, that there might be pending not yet expired events on
other CPUs, which are in the idle broadcast state. So the delivery of
those events can be delayed for quite a time.
Change the tick_handle_oneshot_broadcast() function to check for CPUs,
which are in broadcast state and are not woken up by the current event,
and enforce the rearming of the broadcast device for those CPUs.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions