diff options
| author | Maciej S. Szmigiero <mail@maciej.szmigiero.name> | 2018-02-14 00:04:58 +0100 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2018-02-14 07:46:50 +0100 |
| commit | a4463c92db0805581f4dfb700f72533cf25ebd48 (patch) | |
| tree | 20e678073eb4543ae0512ee19361abbd7ae916e8 /include/sound | |
| parent | bafeca673f04ecd54cbb6b87faf8d525a886d481 (diff) | |
| download | linux-a4463c92db0805581f4dfb700f72533cf25ebd48.tar.bz2 | |
ALSA: emu10k1: remove reserved_page
The emu10k1-family chips need the first page (index 0) reserved in their
page tables for some reason (every emu10k1 driver I've checked does this
without much of an explanation).
Using the first page for normal samples results in a broken playback.
However, we already have a dummy page allocated - so called "silent page"
and, in fact, had always been setting it as the first page in the chip page
table because an initialization of every entry of the page table to point
to a silent page happens after and overwrites the reserved_page allocation.
So the only thing remaining to remove the reserved_page allocation is a
trivial change to the page allocation logic to ignore the first page entry
and start its allocations from the second entry (index 1).
Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'include/sound')
| -rw-r--r-- | include/sound/emu10k1.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/include/sound/emu10k1.h b/include/sound/emu10k1.h index 4f42affe777c..db32b7de52e0 100644 --- a/include/sound/emu10k1.h +++ b/include/sound/emu10k1.h @@ -1718,7 +1718,6 @@ struct snd_emu10k1 { struct snd_dma_buffer p16v_buffer; struct snd_util_memhdr *memhdr; /* page allocation list */ - struct snd_emu10k1_memblk *reserved_page; /* reserved page */ struct list_head mapped_link_head; struct list_head mapped_order_link_head; |