diff options
author | Xie He <xie.he.0141@gmail.com> | 2020-09-16 05:23:08 -0700 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2020-09-17 16:24:45 -0700 |
commit | b79a80bd6dd85e284b160734c86a1caaa9c54f6f (patch) | |
tree | 8a5d58614be60dfdce8d3be8c5bf9ecfe4a2fa66 /include/net/slhc_vj.h | |
parent | 31660a97665272ce2b5f4ddf5b3268bcba01e433 (diff) | |
download | linux-b79a80bd6dd85e284b160734c86a1caaa9c54f6f.tar.bz2 |
net/packet: Fix a comment about mac_header
1. Change all "dev->hard_header" to "dev->header_ops"
2. On receiving incoming frames when header_ops == NULL:
The comment only says what is wrong, but doesn't say what is right.
This patch changes the comment to make it clear what is right.
3. On transmitting and receiving outgoing frames when header_ops == NULL:
The comment explains that the LL header will be later added by the driver.
However, I think it's better to simply say that the LL header is invisible
to us. This phrasing is better from a software engineering perspective,
because this makes it clear that what happens in the driver should be
hidden from us and we should not care about what happens internally in the
driver.
4. On resuming the LL header (for RAW frames) when header_ops == NULL:
The comment says we are "unlikely" to restore the LL header.
However, we should say that we are "unable" to restore it.
It's not possible (rather than not likely) to restore it, because:
1) There is no way for us to restore because the LL header internally
processed by the driver should be invisible to us.
2) In function packet_rcv and tpacket_rcv, the code only tries to restore
the LL header when header_ops != NULL.
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Signed-off-by: Xie He <xie.he.0141@gmail.com>
Acked-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/net/slhc_vj.h')
0 files changed, 0 insertions, 0 deletions