diff options
author | Lyude Paul <lyude@redhat.com> | 2019-09-03 16:45:55 -0400 |
---|---|---|
committer | Lyude Paul <lyude@redhat.com> | 2019-09-25 16:35:15 -0400 |
commit | e2839ff692c628a5a1caa6721e45ab5d212f9aca (patch) | |
tree | 80aae5bdae4eebaa52f9b19ea3fdca318fd3ffd7 /include/drm | |
parent | 50094b5dcd3238c0cf91a5768d0316adaeb32e45 (diff) | |
download | linux-e2839ff692c628a5a1caa6721e45ab5d212f9aca.tar.bz2 |
drm/dp_mst: Rename drm_dp_add_port and drm_dp_update_port
The names for these functions are rather confusing. drm_dp_add_port()
sounds like a function that would simply create a port and add it to a
topology, and do nothing more. Similarly, drm_dp_update_port() would be
assumed to be the function that should be used to update port
information after initial creation.
While those assumptions are currently correct in how these functions are
used, a quick glance at drm_dp_add_port() reveals that drm_dp_add_port()
can also update the information on a port, and seems explicitly designed
to do so. This can be explained pretty simply by the fact that there's
more situations that would involve updating the port information based
on a link address response as opposed to a connection status
notification than the driver's initial topology probe. Case in point:
reprobing link addresses after suspend/resume.
Since we're about to start using drm_dp_add_port() differently for
suspend/resume reprobing, let's rename both functions to clarify what
they actually do.
Cc: Juston Li <juston.li@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Harry Wentland <hwentlan@amd.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Sean Paul <sean@poorly.run>
Link: https://patchwork.freedesktop.org/patch/msgid/20190903204645.25487-18-lyude@redhat.com
Diffstat (limited to 'include/drm')
0 files changed, 0 insertions, 0 deletions