diff options
author | Song Liu <songliubraving@fb.com> | 2021-09-29 12:43:13 -0700 |
---|---|---|
committer | Peter Zijlstra <peterz@infradead.org> | 2021-10-01 13:57:54 +0200 |
commit | f792565326825ed806626da50c6f9a928f1079c1 (patch) | |
tree | 09c2e29ea3fb5732a50748230db362bbd44fab5c /include/drm/drm_utils.h | |
parent | ecc2123e09f9e71ddc6c53d71e283b8ada685fe2 (diff) | |
download | linux-f792565326825ed806626da50c6f9a928f1079c1.tar.bz2 |
perf/core: fix userpage->time_enabled of inactive events
Users of rdpmc rely on the mmapped user page to calculate accurate
time_enabled. Currently, userpage->time_enabled is only updated when the
event is added to the pmu. As a result, inactive event (due to counter
multiplexing) does not have accurate userpage->time_enabled. This can
be reproduced with something like:
/* open 20 task perf_event "cycles", to create multiplexing */
fd = perf_event_open(); /* open task perf_event "cycles" */
userpage = mmap(fd); /* use mmap and rdmpc */
while (true) {
time_enabled_mmap = xxx; /* use logic in perf_event_mmap_page */
time_enabled_read = read(fd).time_enabled;
if (time_enabled_mmap > time_enabled_read)
BUG();
}
Fix this by updating userpage for inactive events in merge_sched_in.
Suggested-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reported-and-tested-by: Lucian Grijincu <lucian@fb.com>
Signed-off-by: Song Liu <songliubraving@fb.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20210929194313.2398474-1-songliubraving@fb.com
Diffstat (limited to 'include/drm/drm_utils.h')
0 files changed, 0 insertions, 0 deletions