diff options
| author | Steve French <stfrench@microsoft.com> | 2021-11-11 15:35:34 -0600 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2021-11-12 12:59:54 -0600 |
| commit | ca780da5fdd389d391eff5ac954ee8b91953125d (patch) | |
| tree | 04323135fdb5544faffcdf802775d3f30eb46abe /fs | |
| parent | 9e7ffa77b26a8a00a12b6631aa13f161d9900b0c (diff) | |
| download | linux-ca780da5fdd389d391eff5ac954ee8b91953125d.tar.bz2 | |
smb3: add additional null check in SMB311_posix_mkdir
Although unlikely for it to be possible for rsp to be null here,
the check is safer to add, and quiets a Coverity warning.
Addresses-Coverity: 1437501 ("Explicit Null dereference")
Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/cifs/smb2pdu.c | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c index 243de87b2d6d..5e032b2b2adb 100644 --- a/fs/cifs/smb2pdu.c +++ b/fs/cifs/smb2pdu.c @@ -2668,7 +2668,18 @@ int smb311_posix_mkdir(const unsigned int xid, struct inode *inode, goto err_free_rsp_buf; } + /* + * Although unlikely to be possible for rsp to be null and rc not set, + * adding check below is slightly safer long term (and quiets Coverity + * warning) + */ rsp = (struct smb2_create_rsp *)rsp_iov.iov_base; + if (rsp == NULL) { + rc = -EIO; + kfree(pc_buf); + goto err_free_req; + } + trace_smb3_posix_mkdir_done(xid, le64_to_cpu(rsp->PersistentFileId), tcon->tid, ses->Suid, CREATE_NOT_FILE, |