summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorJan Kara <jack@suse.cz>2016-10-24 14:20:25 +1100
committerDave Chinner <david@fromorbit.com>2016-10-24 14:20:25 +1100
commitc663e29f8885269c1608b5aa6057729fa9267b35 (patch)
treefffb106bd365d9f74d14ef9519edbf265e9f228a /fs
parent64e6428ddd00f864e3ca105f914a2b6920c2bc41 (diff)
downloadlinux-c663e29f8885269c1608b5aa6057729fa9267b35.tar.bz2
fs: Do to trim high file position bits in iomap_page_mkwrite_actor
iomap_page_mkwrite_actor() calls __block_write_begin_int() with position masked as pos & ~PAGE_MASK which is equivalent to pos & (PAGE_SIZE-1). Thus it masks off high bits of file position. However __block_write_begin_int() expects full file position on input. This does not cause any visible issues because all __block_write_begin_int() really cares about are low file position bits but still it is a bug waiting to happen. Signed-off-by: Jan Kara <jack@suse.cz> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Dave Chinner <david@fromorbit.com>
Diffstat (limited to 'fs')
-rw-r--r--fs/iomap.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/iomap.c b/fs/iomap.c
index a92204012e2d..a8ee8c33ca78 100644
--- a/fs/iomap.c
+++ b/fs/iomap.c
@@ -433,8 +433,7 @@ iomap_page_mkwrite_actor(struct inode *inode, loff_t pos, loff_t length,
struct page *page = data;
int ret;
- ret = __block_write_begin_int(page, pos & ~PAGE_MASK, length,
- NULL, iomap);
+ ret = __block_write_begin_int(page, pos, length, NULL, iomap);
if (ret)
return ret;