summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorZev Weiss <zev@bewilderbeest.net>2018-04-14 01:16:58 -0500
committerAl Viro <viro@zeniv.linux.org.uk>2018-04-15 23:36:26 -0400
commit22762711479959754e005f5bb8e6abc37bf9e0ba (patch)
tree5d68bdb49a6908d061fe46a1c3c084708a35d286 /fs
parent60cc43fc888428bb2f18f08997432d426a243338 (diff)
downloadlinux-22762711479959754e005f5bb8e6abc37bf9e0ba.tar.bz2
fs: avoid fdput() after failed fdget() in vfs_dedupe_file_range()
It's a fairly inconsequential bug, since fdput() won't actually try to fput() the file due to fd.flags (and thus FDPUT_FPUT) being zero in the failure case, but most other vfs code takes steps to avoid this. Signed-off-by: Zev Weiss <zev@bewilderbeest.net> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs')
-rw-r--r--fs/read_write.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/read_write.c b/fs/read_write.c
index c4eabbfc90df..e83bd9744b5d 100644
--- a/fs/read_write.c
+++ b/fs/read_write.c
@@ -2023,7 +2023,7 @@ int vfs_dedupe_file_range(struct file *file, struct file_dedupe_range *same)
ret = mnt_want_write_file(dst_file);
if (ret) {
info->status = ret;
- goto next_loop;
+ goto next_fdput;
}
dst_off = info->dest_offset;
@@ -2058,9 +2058,9 @@ int vfs_dedupe_file_range(struct file *file, struct file_dedupe_range *same)
next_file:
mnt_drop_write_file(dst_file);
-next_loop:
+next_fdput:
fdput(dst_fd);
-
+next_loop:
if (fatal_signal_pending(current))
goto out;
}