diff options
| author | Darrick J. Wong <darrick.wong@oracle.com> | 2016-12-19 15:13:26 -0800 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2016-12-22 23:00:23 -0500 |
| commit | 22725ce4e4a00fbc37694e25dc5c8acef8ad1c28 (patch) | |
| tree | c2f79e95c3aba6279faa3967a14ac9cd0d629022 /fs/xfs | |
| parent | 33844e665104b169a3a7732bdcddb40e4f82b335 (diff) | |
| download | linux-22725ce4e4a00fbc37694e25dc5c8acef8ad1c28.tar.bz2 | |
vfs: fix isize/pos/len checks for reflink & dedupe
Strengthen the checking of pos/len vs. i_size, clarify the return values
for the clone prep function, and remove pointless code.
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/xfs')
| -rw-r--r-- | fs/xfs/xfs_reflink.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/xfs/xfs_reflink.c b/fs/xfs/xfs_reflink.c index aca2d4bd4303..07593a362cd0 100644 --- a/fs/xfs/xfs_reflink.c +++ b/fs/xfs/xfs_reflink.c @@ -1161,7 +1161,7 @@ xfs_reflink_remap_range( ret = vfs_clone_file_prep_inodes(inode_in, pos_in, inode_out, pos_out, &len, is_dedupe); - if (ret || len == 0) + if (ret <= 0) goto out_unlock; trace_xfs_reflink_remap_range(src, pos_in, len, dest, pos_out); |