diff options
| author | kbuild test robot <fengguang.wu@intel.com> | 2014-12-01 08:42:52 +1100 |
|---|---|---|
| committer | Dave Chinner <david@fromorbit.com> | 2014-12-01 08:42:52 +1100 |
| commit | d254aaec5d1aa2997dad035db340c298eaa8d089 (patch) | |
| tree | 61835f26b74687ac2e7d76bcc460539b2bbbe7b7 /fs/xfs | |
| parent | 8300475ebf03a54ec3c56b6b808ccbd9e1bc320d (diff) | |
| download | linux-d254aaec5d1aa2997dad035db340c298eaa8d089.tar.bz2 | |
xfs: fix simple_return.cocci warning in xfs_bmse_shift_one
fs/xfs/libxfs/xfs_bmap.c:5591:1-6: WARNING: end returns can be simpified
Simplify a trivial if-return sequence. Possibly combine with a
preceding function call.
Generated by: scripts/coccinelle/misc/simple_return.cocci
CC: Brian Foster <bfoster@redhat.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Diffstat (limited to 'fs/xfs')
| -rw-r--r-- | fs/xfs/libxfs/xfs_bmap.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c index 79c981984dca..20d2e96aef6a 100644 --- a/fs/xfs/libxfs/xfs_bmap.c +++ b/fs/xfs/libxfs/xfs_bmap.c @@ -5592,12 +5592,8 @@ shift_extent: XFS_WANT_CORRUPTED_GOTO(i == 1, out_error); got.br_startoff = startoff; - error = xfs_bmbt_update(cur, got.br_startoff, got.br_startblock, + return xfs_bmbt_update(cur, got.br_startoff, got.br_startblock, got.br_blockcount, got.br_state); - if (error) - return error; - - return 0; out_error: return error; |