diff options
author | Tim Pepper <lnxninja@linux.vnet.ibm.com> | 2007-10-11 22:11:11 +0200 |
---|---|---|
committer | Peter Zijlstra <a.p.zijlstra@chello.nl> | 2007-10-11 22:11:11 +0200 |
commit | 94c61c0aeffe64452e742087cf803d0347ef8418 (patch) | |
tree | 95d836151d8239bb0303d4903d31b4c5180aa40b /fs/xfs | |
parent | 512e67f991c8886de75a65b854d7c19a55fb5b8a (diff) | |
download | linux-94c61c0aeffe64452e742087cf803d0347ef8418.tar.bz2 |
lockdep: Avoid /proc/lockdep & lock_stat infinite output
Both /proc/lockdep and /proc/lock_stat output may loop infinitely.
When a read() requests an amount of data smaller than the amount of data
that the seq_file's foo_show() outputs, the output starts looping and
outputs the "stuck" element's data infinitely. There may be multiple
sequential calls to foo_start(), foo_next()/foo_show(), and foo_stop()
for a single open with sequential read of the file. The _start() does not
have to start with the 0th element and _show() might be called multiple
times in a row for the same element for a given open/read of the seq_file.
Also header output should not be happening in _start(). All output should
be in _show(), which SEQ_START_TOKEN is meant to help. Having output in
_start() may also negatively impact seq_file's seq_read() and traverse()
accounting.
Signed-off-by: Tim Pepper <lnxninja@linux.vnet.ibm.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Al Viro <viro@ftp.linux.org.uk>
Diffstat (limited to 'fs/xfs')
0 files changed, 0 insertions, 0 deletions