diff options
| author | Dave Chinner <dchinner@redhat.com> | 2010-12-20 11:57:24 +1100 |
|---|---|---|
| committer | Dave Chinner <david@fromorbit.com> | 2010-12-20 11:57:24 +1100 |
| commit | 9c5f8414efd5eeed9f498d4170337a3eb126341f (patch) | |
| tree | 5801d0cbd2f37cc72e0b541231c60e281c27d874 /fs/xfs/xfs_extfree_item.h | |
| parent | 821eb21d97a8b686649c08b7284d0b9f34d0e138 (diff) | |
| download | linux-9c5f8414efd5eeed9f498d4170337a3eb126341f.tar.bz2 | |
xfs: fix EFI transaction cancellation.
XFS_EFI_CANCELED has not been set in the code base since
xfs_efi_cancel() was removed back in 2006 by commit
065d312e15902976d256ddaf396a7950ec0350a8 ("[XFS] Remove unused
iop_abort log item operation), and even then xfs_efi_cancel() was
never called. I haven't tracked it back further than that (beyond
git history), but it indicates that the handling of EFIs in
cancelled transactions has been broken for a long time.
Basically, when we get an IOP_UNPIN(lip, 1); call from
xfs_trans_uncommit() (i.e. remove == 1), if we don't free the log
item descriptor we leak it. Fix the behviour to be correct and kill
the XFS_EFI_CANCELED flag.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'fs/xfs/xfs_extfree_item.h')
| -rw-r--r-- | fs/xfs/xfs_extfree_item.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/xfs/xfs_extfree_item.h b/fs/xfs/xfs_extfree_item.h index 0d22c56fdf64..f7834ec8efad 100644 --- a/fs/xfs/xfs_extfree_item.h +++ b/fs/xfs/xfs_extfree_item.h @@ -115,7 +115,6 @@ typedef struct xfs_efd_log_format_64 { */ #define XFS_EFI_RECOVERED 0x1 #define XFS_EFI_COMMITTED 0x2 -#define XFS_EFI_CANCELED 0x4 /* * This is the "extent free intention" log item. It is used |