summaryrefslogtreecommitdiffstats
path: root/fs/xfs/xfs_ag.h
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@infradead.org>2009-08-16 20:36:34 -0400
committerFelix Blyakher <felixb@sgi.com>2009-08-17 01:23:48 -0500
commitbc990f5cb424cdca9dda866785d088e2c2110ecc (patch)
tree4264beb9538533d136e41f0e93933160fe925008 /fs/xfs/xfs_ag.h
parent894ef820b10d77e2d6d717342fc408bdd9825139 (diff)
downloadlinux-bc990f5cb424cdca9dda866785d088e2c2110ecc.tar.bz2
xfs: fix locking in xfs_iget_cache_hit
The locking in xfs_iget_cache_hit currently has numerous problems: - we clear the reclaim tag without i_flags_lock which protects modifications to it - we call inode_init_always which can sleep with pag_ici_lock held (this is oss.sgi.com BZ #819) - we acquire and drop i_flags_lock a lot and thus provide no consistency between the various flags we set/clear under it This patch fixes all that with a major revamp of the locking in the function. The new version acquires i_flags_lock early and only drops it once we need to call into inode_init_always or before calling xfs_ilock. This patch fixes a bug seen in the wild where we race modifying the reclaim tag. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Felix Blyakher <felixb@sgi.com> Reviewed-by: Eric Sandeen <sandeen@sandeen.net> Signed-off-by: Felix Blyakher <felixb@sgi.com>
Diffstat (limited to 'fs/xfs/xfs_ag.h')
0 files changed, 0 insertions, 0 deletions