summaryrefslogtreecommitdiffstats
path: root/fs/xfs/libxfs
diff options
context:
space:
mode:
authorDarrick J. Wong <darrick.wong@oracle.com>2018-05-22 11:48:08 -0700
committerDarrick J. Wong <darrick.wong@oracle.com>2018-05-29 10:46:03 -0700
commitaee9a4a555b3f1440cc3943d7b9ab5fa072ec62e (patch)
treed4d643d27b737da3bb16faf39700580b2b2995e4 /fs/xfs/libxfs
parent19e129618d47987618c71c4f129ba8dfa2669569 (diff)
downloadlinux-aee9a4a555b3f1440cc3943d7b9ab5fa072ec62e.tar.bz2
fs: clear writeback errors in inode_init_always
In inode_init_always(), we clear the inode mapping flags, which clears any retained error (AS_EIO, AS_ENOSPC) bits. Unfortunately, we do not also clear wb_err, which means that old mapping errors can leak through to new inodes. This is crucial for the XFS inode allocation path because we recycle old in-core inodes and we do not want error state from an old file to leak into the new file. This bug was discovered by running generic/036 and generic/047 in a loop and noticing that the EIOs generated by the collision of direct and buffered writes in generic/036 would survive the remount between 036 and 047, and get reported to the fsyncs (on different files!) in generic/047. Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> Reviewed-by: Jeff Layton <jlayton@kernel.org> Reviewed-by: Brian Foster <bfoster@redhat.com>
Diffstat (limited to 'fs/xfs/libxfs')
0 files changed, 0 insertions, 0 deletions