diff options
author | Zhihao Cheng <chengzhihao1@huawei.com> | 2020-06-01 17:10:36 +0800 |
---|---|---|
committer | Richard Weinberger <richard@nod.at> | 2020-09-17 22:55:41 +0200 |
commit | f2aae745b82c842221f4f233051f9ac641790959 (patch) | |
tree | 4091cc20db14a01b693ace43b6206ad824d1816d /fs/ubifs/orphan.c | |
parent | e4c26faa426c17274884f759f708bc9ee22fd59a (diff) | |
download | linux-f2aae745b82c842221f4f233051f9ac641790959.tar.bz2 |
ubifs: xattr: Fix some potential memory leaks while iterating entries
Fix some potential memory leaks in error handling branches while
iterating xattr entries. For example, function ubifs_tnc_remove_ino()
forgets to free pxent if it exists. Similar problems also exist in
ubifs_purge_xattrs(), ubifs_add_orphan() and ubifs_jnl_write_inode().
Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
Cc: <stable@vger.kernel.org>
Fixes: 1e51764a3c2ac05a2 ("UBIFS: add new flash file system")
Signed-off-by: Richard Weinberger <richard@nod.at>
Diffstat (limited to 'fs/ubifs/orphan.c')
-rw-r--r-- | fs/ubifs/orphan.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/ubifs/orphan.c b/fs/ubifs/orphan.c index 2c294085ffed..0fb61956146d 100644 --- a/fs/ubifs/orphan.c +++ b/fs/ubifs/orphan.c @@ -173,6 +173,7 @@ int ubifs_add_orphan(struct ubifs_info *c, ino_t inum) err = PTR_ERR(xent); if (err == -ENOENT) break; + kfree(pxent); return err; } @@ -182,6 +183,7 @@ int ubifs_add_orphan(struct ubifs_info *c, ino_t inum) xattr_orphan = orphan_add(c, xattr_inum, orphan); if (IS_ERR(xattr_orphan)) { + kfree(pxent); kfree(xent); return PTR_ERR(xattr_orphan); } |