diff options
| author | Richard Weinberger <richard@nod.at> | 2019-09-20 08:54:29 +0200 |
|---|---|---|
| committer | Richard Weinberger <richard@nod.at> | 2019-11-17 22:15:28 +0100 |
| commit | b27b281f9cfa9153fe9d40dd07cbbdc58be0c7c6 (patch) | |
| tree | 5fb6181218b2a75fd99b1fcebc63cd6bfd523c0a /fs/ubifs/debug.c | |
| parent | 0997187767425f24518c876a51bb587eb64e02fd (diff) | |
| download | linux-b27b281f9cfa9153fe9d40dd07cbbdc58be0c7c6.tar.bz2 | |
ubifs: Remove obsolete TODO from dfs_file_write()
AFAICT this kind of problems are no longer possible since
debugfs gained file removal protection via
e9117a5a4bf6 ("debugfs: implement per-file removal protection").
Cc: Christoph Hellwig <hch@lst.de>
Cc: Nicolai Stange <nicstange@gmail.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
Diffstat (limited to 'fs/ubifs/debug.c')
| -rw-r--r-- | fs/ubifs/debug.c | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c index e4b52783819d..0f5a480fe264 100644 --- a/fs/ubifs/debug.c +++ b/fs/ubifs/debug.c @@ -2737,18 +2737,6 @@ static ssize_t dfs_file_write(struct file *file, const char __user *u, struct dentry *dent = file->f_path.dentry; int val; - /* - * TODO: this is racy - the file-system might have already been - * unmounted and we'd oops in this case. The plan is to fix it with - * help of 'iterate_supers_type()' which we should have in v3.0: when - * a debugfs opened, we rember FS's UUID in file->private_data. Then - * whenever we access the FS via a debugfs file, we iterate all UBIFS - * superblocks and fine the one with the same UUID, and take the - * locking right. - * - * The other way to go suggested by Al Viro is to create a separate - * 'ubifs-debug' file-system instead. - */ if (file->f_path.dentry == d->dfs_dump_lprops) { ubifs_dump_lprops(c); return count; |