summaryrefslogtreecommitdiffstats
path: root/fs/reiserfs
diff options
context:
space:
mode:
authorQu Wenruo <wqu@suse.com>2018-09-07 14:16:24 +0800
committerDavid Sterba <dsterba@suse.com>2018-10-15 17:23:32 +0200
commit6ba9fc8e628becf0e3ec94083450d089b0dec5f5 (patch)
tree5dcc345389e7dd618cd6bde4d31855f02efb26c3 /fs/reiserfs
parent93bba24d4b5ad1e5cd8b43f64e66ff9d6355dd20 (diff)
downloadlinux-6ba9fc8e628becf0e3ec94083450d089b0dec5f5.tar.bz2
btrfs: Ensure btrfs_trim_fs can trim the whole filesystem
[BUG] fstrim on some btrfs only trims the unallocated space, not trimming any space in existing block groups. [CAUSE] Before fstrim_range passed to btrfs_trim_fs(), it gets truncated to range [0, super->total_bytes). So later btrfs_trim_fs() will only be able to trim block groups in range [0, super->total_bytes). While for btrfs, any bytenr aligned to sectorsize is valid, since btrfs uses its logical address space, there is nothing limiting the location where we put block groups. For filesystem with frequent balance, it's quite easy to relocate all block groups and bytenr of block groups will start beyond super->total_bytes. In that case, btrfs will not trim existing block groups. [FIX] Just remove the truncation in btrfs_ioctl_fitrim(), so btrfs_trim_fs() can get the unmodified range, which is normally set to [0, U64_MAX]. Reported-by: Chris Murphy <lists@colorremedies.com> Fixes: f4c697e6406d ("btrfs: return EINVAL if start > total_bytes in fitrim ioctl") CC: <stable@vger.kernel.org> # v4.4+ Signed-off-by: Qu Wenruo <wqu@suse.com> Reviewed-by: Nikolay Borisov <nborisov@suse.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/reiserfs')
0 files changed, 0 insertions, 0 deletions