diff options
| author | Eric W. Biederman <ebiederm@xmission.com> | 2006-06-26 00:25:42 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-06-26 09:58:23 -0700 |
| commit | 167965495153ba9829d0a34b6800dbf5d94de8c8 (patch) | |
| tree | ee923581fc2fb1a9bcae7920a8a362fed7b55705 /fs/proc | |
| parent | ff9724a3f7a69f7b443c05981f84e28017c2fc5a (diff) | |
| download | linux-167965495153ba9829d0a34b6800dbf5d94de8c8.tar.bz2 | |
[PATCH] proc: Remove unnecessary and misleading assignments from proc_pid_make_inode
The removed fields are already set by proc_alloc_inode. Initializing them in
proc_alloc_inode implies they need it for proper cleanup. At least ei->pde
was not set on all paths making it look like proc_alloc_inode was buggy. So
just remove the redundant assignments.
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs/proc')
| -rw-r--r-- | fs/proc/base.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/proc/base.c b/fs/proc/base.c index 7169a713da1b..0762bc34d98b 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -1357,7 +1357,6 @@ static struct inode *proc_pid_make_inode(struct super_block * sb, struct task_st /* Common stuff */ ei = PROC_I(inode); - ei->task = NULL; inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME; inode->i_ino = fake_ino(task->pid, ino); @@ -1382,7 +1381,6 @@ out: return inode; out_unlock: - ei->pde = NULL; iput(inode); return NULL; } |