summaryrefslogtreecommitdiffstats
path: root/fs/omfs
diff options
context:
space:
mode:
authorAl Viro <viro@zeniv.linux.org.uk>2011-07-26 02:34:33 -0400
committerAl Viro <viro@zeniv.linux.org.uk>2011-07-26 13:05:28 -0400
commit41c96486f238e6a545f52215f95fe69748abf603 (patch)
tree580a8706552a41a0e154b440bd7afd80a9e688da /fs/omfs
parent569254b0cc4e125ffde48780b215ecaf5f72bbf4 (diff)
downloadlinux-41c96486f238e6a545f52215f95fe69748abf603.tar.bz2
omfs: fix (mode & S_IFDIR) abuse
granted, on a filesystem that has only regular files and directories it happens to work, but really should be S_ISDIR(mode)... Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/omfs')
-rw-r--r--fs/omfs/dir.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/omfs/dir.c b/fs/omfs/dir.c
index 3b8d3979e03b..98e544274390 100644
--- a/fs/omfs/dir.c
+++ b/fs/omfs/dir.c
@@ -93,7 +93,7 @@ int omfs_make_empty(struct inode *inode, struct super_block *sb)
memset(bh->b_data, 0, sizeof(struct omfs_inode));
- if (inode->i_mode & S_IFDIR) {
+ if (S_ISDIR(inode->i_mode)) {
memset(&bh->b_data[OMFS_DIR_START], 0xff,
sbi->s_sys_blocksize - OMFS_DIR_START);
} else