diff options
author | Christoph Hellwig <hch@lst.de> | 2017-02-20 07:21:33 +0100 |
---|---|---|
committer | J. Bruce Fields <bfields@redhat.com> | 2017-02-21 10:13:37 -0500 |
commit | 783112f7401ff449d979530209b3f6c2594fdb4e (patch) | |
tree | 82ecfc2b095ecd229746b57100bc789bd403a009 /fs/nls/nls_iso8859-7.c | |
parent | 758e99fefe1d9230111296956335cd35995c0eaf (diff) | |
download | linux-783112f7401ff449d979530209b3f6c2594fdb4e.tar.bz2 |
nfsd: special case truncates some more
Both the NFS protocols and the Linux VFS use a setattr operation with a
bitmap of attributes to set to set various file attributes including the
file size and the uid/gid.
The Linux syscalls never mix size updates with unrelated updates like
the uid/gid, and some file systems like XFS and GFS2 rely on the fact
that truncates don't update random other attributes, and many other file
systems handle the case but do not update the other attributes in the
same transaction. NFSD on the other hand passes the attributes it gets
on the wire more or less directly through to the VFS, leading to updates
the file systems don't expect. XFS at least has an assert on the
allowed attributes, which caught an unusual NFS client setting the size
and group at the same time.
To handle this issue properly this splits the notify_change call in
nfsd_setattr into two separate ones.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Cc: stable@vger.kernel.org
Tested-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'fs/nls/nls_iso8859-7.c')
0 files changed, 0 insertions, 0 deletions