diff options
| author | Kinglong Mee <kinglongmee@gmail.com> | 2013-12-23 17:31:21 +0800 |
|---|---|---|
| committer | J. Bruce Fields <bfields@redhat.com> | 2014-01-03 18:18:47 -0500 |
| commit | f403e450e85cd403b63fd163d29b6b7f5e8eaf77 (patch) | |
| tree | 971d4893a058fedca25f24e6710d901edac51a65 /fs/nfsd | |
| parent | 2ce02b6b6cf3532df143b85a72bacd611a55616a (diff) | |
| download | linux-f403e450e85cd403b63fd163d29b6b7f5e8eaf77.tar.bz2 | |
NFSD: fix a leak which can cause CREATE_SESSION failures
check_forechannel_attrs gets drc memory, so nfsd must put it when
check_backchannel_attrs fails.
After many requests with bad back channel attrs, nfsd will deny any
client's CREATE_SESSION forever.
A new test case named CSESS29 for pynfs will send in another mail.
Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'fs/nfsd')
| -rw-r--r-- | fs/nfsd/nfs4state.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index 1aed9be56414..9a6d088247fd 100644 --- a/fs/nfsd/nfs4state.c +++ b/fs/nfsd/nfs4state.c @@ -1915,7 +1915,7 @@ nfsd4_create_session(struct svc_rqst *rqstp, return status; status = check_backchannel_attrs(&cr_ses->back_channel); if (status) - return status; + goto out_release_drc_mem; status = nfserr_jukebox; new = alloc_session(&cr_ses->fore_channel); if (!new) |