diff options
author | J. Bruce Fields <bfields@redhat.com> | 2018-12-20 10:42:36 -0500 |
---|---|---|
committer | Anna Schumaker <Anna.Schumaker@Netapp.com> | 2019-01-02 12:05:19 -0500 |
commit | cb24e35b4fa8448e7ee963884958235b8de44f25 (patch) | |
tree | a527b0c5966f2c2c44b4c318be13c0d27201da39 /fs/nfs/internal.h | |
parent | 81c88b18de1f11f70c97f28ced8d642c00bb3955 (diff) | |
download | linux-cb24e35b4fa8448e7ee963884958235b8de44f25.tar.bz2 |
sunrpc: convert unnecessary GFP_ATOMIC to GFP_NOFS
It's OK to sleep here, we just don't want to recurse into the filesystem
as a writeout could be waiting on this.
Future work: the documentation for GFP_NOFS says "Please try to avoid
using this flag directly and instead use memalloc_nofs_{save,restore} to
mark the whole scope which cannot/shouldn't recurse into the FS layer
with a short explanation why. All allocation requests will inherit
GFP_NOFS implicitly."
But I'm not sure where to do this. Should the workqueue be arranging
that for us in the case of workqueues created with WQ_MEM_RECLAIM?
Reported-by: Trond Myklebust <trondmy@hammer.space>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Diffstat (limited to 'fs/nfs/internal.h')
0 files changed, 0 insertions, 0 deletions