diff options
author | Liu Bo <bo.liu@linux.alibaba.com> | 2018-03-31 06:11:56 +0800 |
---|---|---|
committer | David Sterba <dsterba@suse.com> | 2018-04-12 14:49:47 +0200 |
commit | af7227338135d2f1b1552bf9a6d43e02dcba10b9 (patch) | |
tree | 523dc6fe41ef91ea1328f5f10e15945938f8a34b /fs/fs-writeback.c | |
parent | 1e1c50a929bc9e49bc3f9935b92450d9e69f8158 (diff) | |
download | linux-af7227338135d2f1b1552bf9a6d43e02dcba10b9.tar.bz2 |
Btrfs: clean up resources during umount after trans is aborted
Currently if some fatal errors occur, like all IO get -EIO, resources
would be cleaned up when
a) transaction is being committed or
b) BTRFS_FS_STATE_ERROR is set
However, in some rare cases, resources may be left alone after transaction
gets aborted and umount may run into some ASSERT(), e.g.
ASSERT(list_empty(&block_group->dirty_list));
For case a), in btrfs_commit_transaciton(), there're several places at the
beginning where we just call btrfs_end_transaction() without cleaning up
resources. For case b), it is possible that the trans handle doesn't have
any dirty stuff, then only trans hanlde is marked as aborted while
BTRFS_FS_STATE_ERROR is not set, so resources remain in memory.
This makes btrfs also check BTRFS_FS_STATE_TRANS_ABORTED to make sure that
all resources won't stay in memory after umount.
Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/fs-writeback.c')
0 files changed, 0 insertions, 0 deletions