diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2018-07-06 14:44:45 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-07-07 20:06:08 +0900 |
| commit | be9c64b19b8131459dd7107dc0ae209eeeaa9ce8 (patch) | |
| tree | 7e49e2cfb799b79d76649ddba2051bc0952fcf3a /fs/fhandle.c | |
| parent | e2664f97c38c4f1bef3cbcc69969627c134aee17 (diff) | |
| download | linux-be9c64b19b8131459dd7107dc0ae209eeeaa9ce8.tar.bz2 | |
mlxsw: spectrum_router: avoid uninitialized variable access
When CONFIG_BRIDGE_VLAN_FILTERING is disabled, gcc correctly points out
that the 'vid' variable is uninitialized whenever br_vlan_get_pvid
returns an error:
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c: In function 'mlxsw_sp_rif_vlan_fid_get':
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c:6881:6: error: 'vid' may be used uninitialized in this function [-Werror=maybe-uninitialized]
This changes the condition check to always return -EINVAL here,
which I guess is what the author intended here.
Fixes: e6f1960ae6c7 ("mlxsw: spectrum_router: Allocate FID according to PVID")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'fs/fhandle.c')
0 files changed, 0 insertions, 0 deletions