diff options
author | Jeff Layton <jlayton@redhat.com> | 2011-12-20 06:57:45 -0500 |
---|---|---|
committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2012-01-05 10:42:40 -0500 |
commit | 8a0d551a59ac92d8ff048d6cb29d3a02073e81e8 (patch) | |
tree | df298123c28d66603a80e11728cd5af613ee4730 /fs/dlm/lock.c | |
parent | 2edb6bc3852c681c0d948245bd55108dc6407604 (diff) | |
download | linux-8a0d551a59ac92d8ff048d6cb29d3a02073e81e8.tar.bz2 |
nfs: fix regression in handling of context= option in NFSv4
Setting the security context of a NFSv4 mount via the context= mount
option is currently broken. The NFSv4 codepath allocates a parsed
options struct, and then parses the mount options to fill it. It
eventually calls nfs4_remote_mount which calls security_init_mnt_opts.
That clobbers the lsm_opts struct that was populated earlier. This bug
also looks like it causes a small memory leak on each v4 mount where
context= is used.
Fix this by moving the initialization of the lsm_opts into
nfs_alloc_parsed_mount_data. Also, add a destructor for
nfs_parsed_mount_data to make it easier to free all of the allocations
hanging off of it, and to ensure that the security_free_mnt_opts is
called whenever security_init_mnt_opts is.
I believe this regression was introduced quite some time ago, probably
by commit c02d7adf.
Cc: stable@vger.kernel.org
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Diffstat (limited to 'fs/dlm/lock.c')
0 files changed, 0 insertions, 0 deletions