diff options
author | Tom Rix <trix@redhat.com> | 2020-06-17 05:40:28 -0700 |
---|---|---|
committer | Paul Moore <paul@paul-moore.com> | 2020-06-17 17:36:40 -0400 |
commit | 8231b0b9c322c894594fb42eb0eb9f93544a6acc (patch) | |
tree | 69b85357797d0afd34707c655783a036cae386ec /fs/cifs | |
parent | aa449a7965a6172a89d48844c313708962216f1f (diff) | |
download | linux-8231b0b9c322c894594fb42eb0eb9f93544a6acc.tar.bz2 |
selinux: fix undefined return of cond_evaluate_expr
clang static analysis reports an undefined return
security/selinux/ss/conditional.c:79:2: warning: Undefined or garbage value returned to caller [core.uninitialized.UndefReturn]
return s[0];
^~~~~~~~~~~
static int cond_evaluate_expr( ...
{
u32 i;
int s[COND_EXPR_MAXDEPTH];
for (i = 0; i < expr->len; i++)
...
return s[0];
When expr->len is 0, the loop which sets s[0] never runs.
So return -1 if the loop never runs.
Cc: stable@vger.kernel.org
Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Stephen Smalley <stephen.smalley.work@gmail.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
Diffstat (limited to 'fs/cifs')
0 files changed, 0 insertions, 0 deletions