diff options
author | Anders Roxell <anders.roxell@linaro.org> | 2019-01-29 14:01:46 +0100 |
---|---|---|
committer | David Sterba <dsterba@suse.com> | 2019-02-25 14:13:28 +0100 |
commit | 2eec5f004205be12b5a35628236b593fe1d1cbd5 (patch) | |
tree | ff7673b59e4b842673afd7bf766de1cfa2fcd99e /fs/ceph | |
parent | 766ece54f4c9c29b25eabd091a2ee939feb1669e (diff) | |
download | linux-2eec5f004205be12b5a35628236b593fe1d1cbd5.tar.bz2 |
btrfs: let the assertion expression compile in all configs
A compiler warning (in a patch in development) pointed to a variable
that was used only inside and ASSERT:
u64 root_objectid = root->root_key.objectid;
ASSERT(root_objectid == ...);
fs/btrfs/relocation.c: In function ‘insert_dirty_subv’:
fs/btrfs/relocation.c:2138:6: warning: unused variable ‘root_objectid’ [-Wunused-variable]
u64 root_objectid = root->root_key.objectid;
^~~~~~~~~~~~~
When CONFIG_BRTFS_ASSERT isn't enabled, variable root_objectid isn't used.
Rework the assertion helper by adding a runtime check instead of the
'#ifdef CONFIG_BTRFS_ASSERT #else ...", so the compiler sees the
condition being passed into an inline function after preprocessing.
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Reviewed-by: David Sterba <dsterba@suse.com>
[ update changelog ]
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/ceph')
0 files changed, 0 insertions, 0 deletions