diff options
author | Liu Bo <bo.li.liu@oracle.com> | 2014-07-02 16:58:01 +0800 |
---|---|---|
committer | Chris Mason <clm@fb.com> | 2014-07-03 07:04:15 -0700 |
commit | d288db5dc0110c8e0732d099aaf7a05e2ea0e0c8 (patch) | |
tree | 8f25c749e2d6199d47888278c3a22b5dc066249a /fs/btrfs/ioctl.c | |
parent | 130d5b415a091e493ac1508b9d27bbb85ba7b8c0 (diff) | |
download | linux-d288db5dc0110c8e0732d099aaf7a05e2ea0e0c8.tar.bz2 |
Btrfs: fix race of using total_bytes_pinned
This percpu counter @total_bytes_pinned is introduced to skip unnecessary
operations of 'commit transaction', it accounts for those space we may free
but are stuck in delayed refs.
And we zero out @space_info->total_bytes_pinned every transaction period so
we have a better idea of how much space we'll actually free up by committing
this transaction. However, we do the 'zero out' part a little earlier, before
we actually unpin space, so we end up returning ENOSPC when we actually have
free space that's just unpinned from committing transaction.
xfstests/generic/074 complained then.
This fixes it by actually accounting the percpu pinned number when 'unpin',
and since it's protected by space_info->lock, the race is gone now.
Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
Reviewed-by: Miao Xie <miaox@cn.fujitsu.com>
Signed-off-by: Chris Mason <clm@fb.com>
Diffstat (limited to 'fs/btrfs/ioctl.c')
0 files changed, 0 insertions, 0 deletions