summaryrefslogtreecommitdiffstats
path: root/fs/afs/main.c
diff options
context:
space:
mode:
authorDavid Howells <dhowells@redhat.com>2017-11-02 15:27:49 +0000
committerDavid Howells <dhowells@redhat.com>2017-11-13 15:38:18 +0000
commitbe080a6f43c40976afc950ee55e9b7f8e2b53525 (patch)
tree066232ba94227d23335f5691fff4b697273a7d47 /fs/afs/main.c
parentc435ee34551e1f5a02a253ca8e235287efd2727c (diff)
downloadlinux-be080a6f43c40976afc950ee55e9b7f8e2b53525.tar.bz2
afs: Overhaul permit caching
Overhaul permit caching in AFS by making it per-vnode and sharing permit lists where possible. When most of the fileserver operations are called, they return a status structure indicating the (revised) details of the vnode or vnodes involved in the operation. This includes the access mark derived from the ACL (named CallerAccess in the protocol definition file). This is cacheable and if the ACL changes, the server will tell us that it is breaking the callback promise, at which point we can discard the currently cached permits. With this patch, the afs_permits structure has, at the end, an array of { key, CallerAccess } elements, sorted by key pointer. This is then cached in a hash table so that it can be shared between vnodes with the same access permits. Permit lists can only be shared if they contain the exact same set of key->CallerAccess mappings. Note that that table is global rather than being per-net_ns. If the keys in a permit list cross net_ns boundaries, there is no problem sharing the cached permits, since the permits are just integer masks. Since permit lists pin keys, the permit cache also makes it easier for a future patch to find all occurrences of a key and remove them by means of setting the afs_permits::invalidated flag and then clearing the appropriate key pointer. In such an event, memory barriers will need adding. Lastly, the permit caching is skipped if the server has sent either a vnode-specific or an entire-server callback since the start of the operation. Signed-off-by: David Howells <dhowells@redhat.com>
Diffstat (limited to 'fs/afs/main.c')
-rw-r--r--fs/afs/main.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/afs/main.c b/fs/afs/main.c
index 331c08740861..010e2e1a40f4 100644
--- a/fs/afs/main.c
+++ b/fs/afs/main.c
@@ -186,6 +186,7 @@ static void __exit afs_exit(void)
destroy_workqueue(afs_vlocation_update_worker);
destroy_workqueue(afs_async_calls);
destroy_workqueue(afs_wq);
+ afs_clean_up_permit_cache();
rcu_barrier();
}