diff options
| author | Mikulas Patocka <mpatocka@redhat.com> | 2021-03-22 10:13:54 -0400 |
|---|---|---|
| committer | Mike Snitzer <snitzer@redhat.com> | 2021-03-22 12:32:32 -0400 |
| commit | 5424a0b867e65f1ecf34ffe88d091a4fcbb35bc1 (patch) | |
| tree | 8cf9f00192e905f0d6366378eb67f46039edc2e4 /drivers | |
| parent | 2d669ceb69c276f7637cf760287ca4187add082e (diff) | |
| download | linux-5424a0b867e65f1ecf34ffe88d091a4fcbb35bc1.tar.bz2 | |
dm: don't report "detected capacity change" on device creation
When a DM device is first created it doesn't yet have an established
capacity, therefore the use of set_capacity_and_notify() should be
conditional given the potential for needless pr_info "detected
capacity change" noise even if capacity is 0.
One could argue that the pr_info() in set_capacity_and_notify() is
misplaced, but that position is not held uniformly.
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Fixes: f64d9b2eacb9 ("dm: use set_capacity_and_notify")
Cc: stable@vger.kernel.org
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/md/dm.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/md/dm.c b/drivers/md/dm.c index 50b693d776d6..3f3be9408afa 100644 --- a/drivers/md/dm.c +++ b/drivers/md/dm.c @@ -2036,7 +2036,10 @@ static struct dm_table *__bind(struct mapped_device *md, struct dm_table *t, if (size != dm_get_size(md)) memset(&md->geometry, 0, sizeof(md->geometry)); - set_capacity_and_notify(md->disk, size); + if (!get_capacity(md->disk)) + set_capacity(md->disk, size); + else + set_capacity_and_notify(md->disk, size); dm_table_event_callback(t, event_callback, md); |