diff options
| author | David Lechner <david@lechnology.com> | 2021-10-17 14:01:06 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-10-19 09:40:49 +0200 |
| commit | c3ed761c9e1e4987406671b326dab48a048614ee (patch) | |
| tree | 7f531c051063e13676e9b703e1be626894d39524 /drivers | |
| parent | 15c9a359094ec6251578b02387436bc64f11a477 (diff) | |
| download | linux-c3ed761c9e1e4987406671b326dab48a048614ee.tar.bz2 | |
counter/counter-sysfs: use sysfs_emit everywhere
In the counter subsystem, we are already using sysfs_emit(), but there
were a few places where we were still using sprintf() in *_show()
functions. For consistency and added protections, use sysfs_emit()
everywhere.
Suggested-by: Greg KH <gregkh@linuxfoundation.org>
Acked-by: William Breathitt Gray <vilhelm.gray@gmail.com>
Signed-off-by: David Lechner <david@lechnology.com>
Link: https://lore.kernel.org/r/20211017190106.3472645-1-david@lechnology.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/counter/counter-sysfs.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/counter/counter-sysfs.c b/drivers/counter/counter-sysfs.c index 1ccd771da25f..c2fddbb0d442 100644 --- a/drivers/counter/counter-sysfs.c +++ b/drivers/counter/counter-sysfs.c @@ -113,7 +113,7 @@ static ssize_t counter_comp_u8_show(struct device *dev, /* data should already be boolean but ensure just to be safe */ data = !!data; - return sprintf(buf, "%u\n", (unsigned int)data); + return sysfs_emit(buf, "%u\n", (unsigned int)data); } static ssize_t counter_comp_u8_store(struct device *dev, @@ -196,7 +196,7 @@ static ssize_t counter_comp_u32_show(struct device *dev, case COUNTER_COMP_COUNT_MODE: return sysfs_emit(buf, "%s\n", counter_count_mode_str[data]); default: - return sprintf(buf, "%u\n", (unsigned int)data); + return sysfs_emit(buf, "%u\n", (unsigned int)data); } } @@ -300,7 +300,7 @@ static ssize_t counter_comp_u64_show(struct device *dev, if (err < 0) return err; - return sprintf(buf, "%llu\n", (unsigned long long)data); + return sysfs_emit(buf, "%llu\n", (unsigned long long)data); } static ssize_t counter_comp_u64_store(struct device *dev, @@ -539,7 +539,7 @@ static ssize_t counter_comp_id_show(struct device *dev, { const size_t id = (size_t)to_counter_attribute(attr)->comp.priv; - return sprintf(buf, "%zu\n", id); + return sysfs_emit(buf, "%zu\n", id); } static int counter_comp_id_attr_create(struct device *const dev, |