diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2016-11-26 13:20:58 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-11-29 21:57:14 +0100 |
| commit | d28fb1ffbaf4c3daffe10bf53f863dcb8845a3c1 (patch) | |
| tree | e53d0354d9831445051f8c4cac30c3b6ebb996c0 /drivers | |
| parent | 4e0447cdaf60d00f0cabd78ef0ba1874e23ae464 (diff) | |
| download | linux-d28fb1ffbaf4c3daffe10bf53f863dcb8845a3c1.tar.bz2 | |
staging: sm750fb: fix a type issue in sm750_set_chip_type()
"revId" needs to be unsigned because we use it to test:
if (revId == SM750LE_REVISION_ID) {
and SM750LE_REVISION_ID is ((unsigned char )0xfe).
Fixes: 81dee67e215b ("staging: sm750fb: add sm750 to staging")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/staging/sm750fb/ddk750_chip.c | 2 | ||||
| -rw-r--r-- | drivers/staging/sm750fb/ddk750_chip.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c index 94f59f446322..f59ce5c0867d 100644 --- a/drivers/staging/sm750fb/ddk750_chip.c +++ b/drivers/staging/sm750fb/ddk750_chip.c @@ -14,7 +14,7 @@ logical_chip_type_t sm750_get_chip_type(void) return chip; } -void sm750_set_chip_type(unsigned short devId, char revId) +void sm750_set_chip_type(unsigned short devId, u8 revId) { if (devId == 0x718) chip = SM718; diff --git a/drivers/staging/sm750fb/ddk750_chip.h b/drivers/staging/sm750fb/ddk750_chip.h index e97e8592d973..e63b8b293816 100644 --- a/drivers/staging/sm750fb/ddk750_chip.h +++ b/drivers/staging/sm750fb/ddk750_chip.h @@ -87,7 +87,7 @@ struct initchip_param { }; logical_chip_type_t sm750_get_chip_type(void); -void sm750_set_chip_type(unsigned short devId, char revId); +void sm750_set_chip_type(unsigned short devId, u8 revId); unsigned int sm750_calc_pll_value(unsigned int request, struct pll_value *pll); unsigned int sm750_format_pll_reg(struct pll_value *pPLL); unsigned int ddk750_get_vm_size(void); |