diff options
| author | Philipp Zabel <p.zabel@pengutronix.de> | 2014-02-26 20:41:09 +0100 |
|---|---|---|
| committer | Philipp Zabel <p.zabel@pengutronix.de> | 2014-03-06 17:41:40 +0100 |
| commit | 6ff60d397b172bd89955433bd9e74be4627d7b9e (patch) | |
| tree | e0226524d87b32b048b737381d5abdbc5097835a /drivers | |
| parent | 4d56ed5a009b7d31ecae1dd26c047b8bb0dd9287 (diff) | |
| download | linux-6ff60d397b172bd89955433bd9e74be4627d7b9e.tar.bz2 | |
of: Warn if of_graph_get_next_endpoint is called with the root node
If of_graph_get_next_endpoint is given a parentless node instead of an
endpoint node, it is clearly a bug.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Acked-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/of/base.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/of/base.c b/drivers/of/base.c index b2f223fa47e9..b5e690bd6e9c 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -2028,8 +2028,8 @@ struct device_node *of_graph_get_next_endpoint(const struct device_node *parent, of_node_put(node); } else { port = of_get_parent(prev); - if (!port) - /* Hm, has someone given us the root node ?... */ + if (WARN_ONCE(!port, "%s(): endpoint %s has no parent node\n", + __func__, prev->full_name)) return NULL; /* Avoid dropping prev node refcount to 0. */ |