diff options
| author | Mohammed Gamal <mgamal@redhat.com> | 2018-05-09 10:17:34 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-05-10 15:37:00 -0400 |
| commit | 55be9f25be1ca5bda75c39808fc77e42691bc07f (patch) | |
| tree | 47291791e5b1ad3165e217a0daa1d4a75bf51529 /drivers | |
| parent | df13c59b54a9f8d3e20a2fb565d54eee8dac8768 (diff) | |
| download | linux-55be9f25be1ca5bda75c39808fc77e42691bc07f.tar.bz2 | |
hv_netvsc: Fix net device attach on older Windows hosts
On older windows hosts the net_device instance is returned to
the caller of rndis_filter_device_add() without having the presence
bit set first. This would cause any subsequent calls to network device
operations (e.g. MTU change, channel change) to fail after the device
is detached once, returning -ENODEV.
Instead of returning the device instabce, we take the exit path where
we call netif_device_attach()
Fixes: 7b2ee50c0cd5 ("hv_netvsc: common detach logic")
Signed-off-by: Mohammed Gamal <mgamal@redhat.com>
Reviewed-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/hyperv/rndis_filter.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c index 6b127be781d9..e7ca5b5f39ed 100644 --- a/drivers/net/hyperv/rndis_filter.c +++ b/drivers/net/hyperv/rndis_filter.c @@ -1288,7 +1288,7 @@ struct netvsc_device *rndis_filter_device_add(struct hv_device *dev, rndis_device->link_state ? "down" : "up"); if (net_device->nvsp_version < NVSP_PROTOCOL_VERSION_5) - return net_device; + goto out; rndis_filter_query_link_speed(rndis_device, net_device); |